Final changes for AES GCM encryption streams#8
Merged
ggershinsky merged 3 commits intoggershinsky:gcm_encryption_streamfrom Sep 5, 2023
Merged
Final changes for AES GCM encryption streams#8ggershinsky merged 3 commits intoggershinsky:gcm_encryption_streamfrom
ggershinsky merged 3 commits intoggershinsky:gcm_encryption_streamfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the last few changes for the AES GCM encryption streams (apache#3231).
streamPositionin the output streamCiphersThe main behavior change is that all files will write at least one cipher block. This is to ensure that the file AAD is validated even for empty files. Otherwise, an attacker could replace a metadata file with an empty file (with a valid header) and nothing would detect it.